Fixed loading of Library given a non-absolute path #2265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Givin a relative path is not ideal, but at least allows the CLI to compile the sketch correctly.
3 tasks
cmaglie
added
topic: code
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2265 +/- ##
==========================================
+ Coverage 62.94% 63.01% +0.07%
==========================================
Files 220 220
Lines 19540 19546 +6
==========================================
+ Hits 12299 12317 +18
+ Misses 6151 6142 -9
+ Partials 1090 1087 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
alessio-perugini
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Givin a relative path is not ideal, but at least allows the CLI to compile the sketch correctly.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
This PR makes the
Libraryloader a bit more resilient by allowing relative paths as input.Using relative paths may lead to other problems, but at least this change allows the CLI to not bail out with weird errors.
What is the current behavior?
If a relative path is given (via
directoriesconfiguration inarduino-cli.yaml) in some cases the path composition during compile fails. See #2180 for an example.What is the new behavior?
The compilation succeeds.
Does this PR introduce a breaking change, and is titled accordingly?
No
Other information
Fix #2180